feat(FR-2688): migrate notification item VirtualFolderNode branch to Strawberry V2 by ironAiken2 · Pull Request #6934 · lablup/backend.ai-webui

ironAiken2 · 2026-04-23T03:07:36Z

Resolves #6932 (FR-2688)

Summary

Migrates ... on VirtualFolderNode branch in BAINodeNotificationItem to ... on VFolder (Strawberry V2).
Renames BAIVirtualFolderNodeNotificationItem -> BAIVFolderNotificationItem and adapts field access (metadata.name, toLocalId(id) replacing V1 row_id).

Part of

Epic FR-2572 - Migrate WebUI to Strawberry V2 GraphQL API.

Notes

No backend change required; both VirtualFolderNode and VFolder implement Node.
No existing producer currently supplies a VFolder node ref into notifications (only useStartSession.tsx for sessions), so this PR is preparatory - it aligns the branch with the V2 schema for future consumers.
The unused status field selection was dropped from both the parent BAINodeNotificationItemFragment (V2 VFolder.status is VFolderOperationStatus!, which conflicted with sibling fragments where status is String) and the child fragment, because neither the original nor the migrated component actually read node.status.

Verification

bash scripts/verify.sh -> ALL PASS

Test plan

Existing session notifications continue to render correctly (regression check).
(Smoke) Add a temporary producer feeding a VFolder id through the Node fragment and confirm the branch resolves - not strictly required for merge, but confirms correctness.

ironAiken2 · 2026-04-23T03:07:57Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-04-23T03:10:28Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	8.78% (-0.01% 🔻)	1857/21150
🔴	Branches	7.98% (-0.02% 🔻)	1187/14866
🔴	Functions	5.14% (-0% 🔻)	295/5735
🔴	Lines	8.52% (-0.01% 🔻)	1749/20524

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🔴	`...` / BAIVFolderNotificationItem.tsx	0%	0%	0%	0%

Test suite run success

865 tests passing in 40 suites.

Report generated by 🧪jest coverage report action from 7a7c311

Copilot

Pull request overview

Migrates the vfolder-related notification item UI from the legacy VirtualFolderNode GraphQL type to Strawberry V2’s VFolder type.

Changes:

Updated BAIVFolderNotificationItem to read vfolder name from VFolder.metadata.name and to navigate using toLocalId(VFolder.id) in the /data?folder=... query param.
Updated BAINodeNotificationItem fragment/type-switching to use ... on VFolder and render the updated notification item component.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
react/src/components/BAIVFolderNotificationItem.tsx	Switches fragment from `VirtualFolderNode` → `VFolder`, uses `metadata.name`, and derives the folder query param from `toLocalId(id)`.
react/src/components/BAINodeNotificationItem.tsx	Updates Node fragment and rendering logic to handle `VFolder` and pass the new fragment prop.

Comments suppressed due to low confidence (1)

react/src/components/BAIVFolderNotificationItem.tsx:14

The PR description still contains placeholders (e.g., resolves #NNN (FR-MMM) and unchecked template checklist items). Please replace these with the actual issue/Jira IDs and relevant validation/testing notes so the migration can be tracked and reviewed properly.

graphite-app · 2026-04-30T03:06:21Z

Merge activity

Apr 30, 3:06 AM UTC: yomybaby added this pull request to the Graphite merge queue.
Apr 30, 3:15 AM UTC: Merged by the Graphite merge queue.

…Strawberry V2 (#6934) Resolves #6932 (FR-2688) ## Summary - Migrates `... on VirtualFolderNode` branch in `BAINodeNotificationItem` to `... on VFolder` (Strawberry V2). - Renames `BAIVirtualFolderNodeNotificationItem` -> `BAIVFolderNotificationItem` and adapts field access (`metadata.name`, `toLocalId(id)` replacing V1 `row_id`). ## Part of Epic FR-2572 - Migrate WebUI to Strawberry V2 GraphQL API. ## Notes - No backend change required; both `VirtualFolderNode` and `VFolder` implement `Node`. - No existing producer currently supplies a VFolder node ref into notifications (only `useStartSession.tsx` for sessions), so this PR is preparatory - it aligns the branch with the V2 schema for future consumers. - The unused `status` field selection was dropped from both the parent `BAINodeNotificationItemFragment` (V2 `VFolder.status` is `VFolderOperationStatus!`, which conflicted with sibling fragments where `status` is `String`) and the child fragment, because neither the original nor the migrated component actually read `node.status`. ## Verification - `bash scripts/verify.sh` -> ALL PASS ## Test plan - [ ] Existing session notifications continue to render correctly (regression check). - [ ] (Smoke) Add a temporary producer feeding a VFolder id through the Node fragment and confirm the branch resolves - not strictly required for merge, but confirms correctness.

Copilot AI review requested due to automatic review settings April 23, 2026 03:07

github-actions Bot assigned ironAiken2 Apr 23, 2026

github-actions Bot added the size:M 30~100 LoC label Apr 23, 2026

Copilot started reviewing on behalf of ironAiken2 April 23, 2026 03:08 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch from 0a1150d to 00cf91a Compare April 23, 2026 04:15

ironAiken2 force-pushed the 04-23-feat_fr-2685_migrate_vfolder_selector_queries_to_strawberry_v2_graphql_api branch from 1b1afab to 367890c Compare April 23, 2026 04:15

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch from 00cf91a to 3b0bc91 Compare April 23, 2026 04:35

ironAiken2 force-pushed the 04-23-feat_fr-2685_migrate_vfolder_selector_queries_to_strawberry_v2_graphql_api branch from 367890c to 25bbf35 Compare April 23, 2026 04:35

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch from 3b0bc91 to a61d9ad Compare April 23, 2026 07:13

ironAiken2 force-pushed the 04-23-feat_fr-2685_migrate_vfolder_selector_queries_to_strawberry_v2_graphql_api branch from 25bbf35 to 4282f19 Compare April 23, 2026 07:13

ironAiken2 mentioned this pull request Apr 23, 2026

feat(FR-2691): relocate /data header panels — Dashboard + host-capacity cell #6941

Merged

5 tasks

ironAiken2 force-pushed the 04-23-feat_fr-2685_migrate_vfolder_selector_queries_to_strawberry_v2_graphql_api branch from 4282f19 to e5290d8 Compare April 23, 2026 07:59

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch 2 times, most recently from 24ada4a to 3eb2f5d Compare April 23, 2026 08:35

ironAiken2 force-pushed the 04-23-feat_fr-2685_migrate_vfolder_selector_queries_to_strawberry_v2_graphql_api branch from e5290d8 to 0a342fb Compare April 23, 2026 08:35

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch from 3eb2f5d to 9695c20 Compare April 24, 2026 04:02

ironAiken2 force-pushed the 04-23-feat_fr-2685_migrate_vfolder_selector_queries_to_strawberry_v2_graphql_api branch from 0a342fb to 5ae9335 Compare April 24, 2026 04:02

ironAiken2 mentioned this pull request Apr 24, 2026

feat(FR-2696): create project admin data page #6962

Merged

5 tasks

ironAiken2 marked this pull request as draft April 24, 2026 04:04

ironAiken2 force-pushed the 04-23-feat_fr-2685_migrate_vfolder_selector_queries_to_strawberry_v2_graphql_api branch from 5ae9335 to 46ee67e Compare April 24, 2026 04:45

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch 2 times, most recently from 05c1b1d to fe08926 Compare April 24, 2026 06:03

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch from f06f603 to 77b09ac Compare April 27, 2026 08:55

ironAiken2 changed the base branch from 04-23-feat_fr-2685_migrate_vfolder_selector_queries_to_strawberry_v2_graphql_api to graphite-base/6934 April 27, 2026 10:00

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch from 77b09ac to f6d48a0 Compare April 27, 2026 10:00

github-actions Bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Apr 27, 2026

ironAiken2 changed the base branch from graphite-base/6934 to 04-24-feat_fr-2696_create_project_admin_data_page April 27, 2026 10:00

ironAiken2 force-pushed the 04-24-feat_fr-2696_create_project_admin_data_page branch from 0381546 to 2ab8da8 Compare April 28, 2026 02:03

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch from f6d48a0 to 35d9e6c Compare April 28, 2026 02:03

ironAiken2 force-pushed the 04-24-feat_fr-2696_create_project_admin_data_page branch from 2ab8da8 to fd60446 Compare April 28, 2026 03:21

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch from 35d9e6c to 7a7c311 Compare April 28, 2026 03:21

ironAiken2 requested review from agatha197, nowgnuesLee and yomybaby April 28, 2026 03:35

ironAiken2 marked this pull request as ready for review April 28, 2026 03:36

ironAiken2 force-pushed the 04-24-feat_fr-2696_create_project_admin_data_page branch from fd60446 to e7a4aca Compare April 29, 2026 01:07

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch 2 times, most recently from 2dcc90f to d05aa9e Compare April 29, 2026 09:59

ironAiken2 force-pushed the 04-24-feat_fr-2696_create_project_admin_data_page branch from e7a4aca to 45b447c Compare April 29, 2026 09:59

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch from d05aa9e to 94c01ea Compare April 29, 2026 10:27

ironAiken2 force-pushed the 04-24-feat_fr-2696_create_project_admin_data_page branch from 45b447c to bbab28e Compare April 29, 2026 10:27

ironAiken2 force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch from 94c01ea to c3f2778 Compare April 30, 2026 00:37

ironAiken2 force-pushed the 04-24-feat_fr-2696_create_project_admin_data_page branch from bbab28e to 497ad1e Compare April 30, 2026 00:37

graphite-app Bot force-pushed the 04-24-feat_fr-2696_create_project_admin_data_page branch from 497ad1e to cd0ca53 Compare April 30, 2026 03:09

graphite-app Bot force-pushed the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch from c3f2778 to 2a84fd4 Compare April 30, 2026 03:10

Base automatically changed from 04-24-feat_fr-2696_create_project_admin_data_page to main April 30, 2026 03:14

graphite-app Bot merged commit 2a84fd4 into main Apr 30, 2026
6 of 7 checks passed

graphite-app Bot deleted the 04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2 branch April 30, 2026 03:15

github-pages Bot had a problem deploying to github-pages April 30, 2026 03:16 Error

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(FR-2688): migrate notification item VirtualFolderNode branch to Strawberry V2#6934

feat(FR-2688): migrate notification item VirtualFolderNode branch to Strawberry V2#6934
graphite-app[bot] merged 1 commit intomainfrom
04-23-feat_fr-2688_migrate_notification_item_virtualfoldernode_branch_to_strawberry_v2

ironAiken2 commented Apr 23, 2026 •

edited

Loading

Uh oh!

ironAiken2 commented Apr 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ironAiken2 commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Part of

Notes

Verification

Test plan

Uh oh!

ironAiken2 commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

graphite-app Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ironAiken2 commented Apr 23, 2026 •

edited

Loading

ironAiken2 commented Apr 23, 2026 •

edited

Loading

github-actions Bot commented Apr 23, 2026 •

edited

Loading

Coverage report for `./react`

graphite-app Bot commented Apr 30, 2026 •

edited

Loading